From 4770908831bda85b7f6d02f3c4059bbcb1112628 Mon Sep 17 00:00:00 2001 From: Sakamoto Shiina <68018796+ShiinaSakamoto@users.noreply.github.com> Date: Fri, 7 Nov 2025 08:09:18 +0900 Subject: [PATCH] [bugfix] Correct postUpdateAction handling in slider component. - Fixed bug where postUpdateAction was not properly passed as a prop to the slider component - Prevented infinite re-renders by removing postUpdateAction from the dependency array --- src-ui/logics/configs/config_page_setter/useSettingsLogics.js | 2 +- .../setting_section/setting_box/_components/slider/Slider.jsx | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src-ui/logics/configs/config_page_setter/useSettingsLogics.js b/src-ui/logics/configs/config_page_setter/useSettingsLogics.js index d3d7c151..c70e22b5 100644 --- a/src-ui/logics/configs/config_page_setter/useSettingsLogics.js +++ b/src-ui/logics/configs/config_page_setter/useSettingsLogics.js @@ -252,7 +252,7 @@ export const useSliderLogic = ({ if (postUpdateAction) { postUpdateAction(); } - }, [current_value.data, postUpdateAction]); + }, [current_value.data]); return { ui_value, diff --git a/src-ui/views/app/config_page/setting_section/setting_box/_components/slider/Slider.jsx b/src-ui/views/app/config_page/setting_section/setting_box/_components/slider/Slider.jsx index d5e81fcf..ea2d7a15 100644 --- a/src-ui/views/app/config_page/setting_section/setting_box/_components/slider/Slider.jsx +++ b/src-ui/views/app/config_page/setting_section/setting_box/_components/slider/Slider.jsx @@ -16,6 +16,7 @@ export const Slider = (props) => { } = useSliderLogic({ current_value: props.current_value, setterFunction: props.setterFunction, + postUpdateAction: props.postUpdateAction, min: props.min, max: props.max, step: props.step,